add type to make collection in test valid#292
Closed
OyvindLGjesdal wants to merge 1 commit intoiiif-prezi:mainfrom
Closed
add type to make collection in test valid#292OyvindLGjesdal wants to merge 1 commit intoiiif-prezi:mainfrom
OyvindLGjesdal wants to merge 1 commit intoiiif-prezi:mainfrom
Conversation
OyvindLGjesdal
changed the title
Contributor
|
It looks like we also need to fix the schema to make sure Collection type is required and has a default. |
Contributor
|
No longer needed if we fix the schema: IIIF/presentation-validator#208 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I looked at examples for using
make_collection_refin the tests and ended up with a manifest not working or validating, since type is required. Thought it would make sense to add it to the test, so that the output of the test is a valid manifest.The
type=Collectioncould maybe be added by the helper method instead, since the function name itself implies that it creates a ref to a collection, but a working example currently could be useful for someone else trying out the library.